Skip to content

Comments

fix: set logger for functional tests#1663

Open
akrejcir wants to merge 1 commit intokubevirt:mainfrom
akrejcir:set-logger-in-tests
Open

fix: set logger for functional tests#1663
akrejcir wants to merge 1 commit intokubevirt:mainfrom
akrejcir:set-logger-in-tests

Conversation

@akrejcir
Copy link
Collaborator

@akrejcir akrejcir commented Jan 23, 2026

What this PR does / why we need it:
When the logger is missing, the test output shows a stack trace.

Which issue(s) this PR fixes:
Fixes: #954

Release note:

None

@akrejcir
fix: set logger for functional tests
1368995 
When the logger is missing, the test output shows a stack trace.

Signed-off-by: Andrej Krejcir <akrejcir@redhat.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Jan 23, 2026
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Jan 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign akrejcir for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 23, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sourcery-ai[bot]
sourcery-ai bot reviewed Jan 23, 2026
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@jcanocan
Copy link
Contributor

jcanocan commented Jan 26, 2026

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2026
@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Feb 2, 2026

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@codingben codingben Awaiting requested review from codingben

@jcanocan jcanocan Awaiting requested review from jcanocan

Assignees

@jcanocan jcanocan

Labels

dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. release-note-none Denotes a PR that doesn't merit a release note. size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[controller-runtime] log.SetLogger(...) was never called; logs will not be displayed.

3 participants

@akrejcir @kubevirt-bot @jcanocan